Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lit optional #306

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Make lit optional #306

merged 3 commits into from
Nov 2, 2023

Conversation

sim-immunant
Copy link
Contributor

Make lit opt-in rather than opt-out, and remove segment checks.

fw-immunant
fw-immunant approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd prefer this as one commit since the scandir change is just a fix to new code.

@sim-immunant sim-immunant merged commit 3d2dec1 into main Nov 2, 2023
20 checks passed
@sim-immunant sim-immunant deleted the optional-lit branch November 2, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fw-immunant fw-immunant fw-immunant approved these changes

@ayrtonm ayrtonm ayrtonm approved these changes

@rinon rinon Awaiting requested review from rinon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sim-immunant @ayrtonm @fw-immunant