Update docs and reorganize repo directory structure #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrtonm
force-pushed
the
am/update_docs
branch
3 times, most recently
from
bffde15 to
0f8edfc
Compare
|
Still need to finish updating docs but I've made all the directory changes and matching CMake fixes |
|
Also CI failures match the last CI run on main so I think all targets should be working same as before. |
|
Pushed a potential fix from the last commit of PR #318. I'm not sure if ignoring the race condition is the right approach, but I still need to get a better understanding of the problem. |
|
Removed the wip commit fixing CI and rebased on top of #318 |
This commit also updates CMake files to keep targets building and LIT running.
fw-immunant
reviewed
Mar 6, 2024
fw-immunant
reviewed
Mar 6, 2024
fw-immunant
reviewed
Mar 6, 2024
fw-immunant
reviewed
Mar 6, 2024
|
TODOs notwithstanding, looks good to me. This is a much more sane layout. |
This commit also updates the LIT config files to point to the new rewriter location and updates CMake files to keep targets working.
This moves libia2, the PartitionAlloc shim and the tracer into the top-level runtime directory. The tracer subdirectory contains the what was previously in the top-level runtime directory. Thiscommit also updates the CMake files to keep targets working.
|
Tests are failing for the same reason as #324 but the docs are in a good enough state to merge. Note that the new docs are not comprehensive, but better than before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes most of the changes initially proposed in #321 and updates the docs. The directory reorganization took pretty minimal work so I'm open to suggestions about any changes that would make things more easily discoverable.