test_fault_handler: exit nonzero if expected segfault missing #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
approved these changes
Jul 24, 2024
kkysen
reviewed
Jul 24, 2024
|
I think we can wait to merge this until we figure out what's wrong with that test and |
|
Do we have an issue on |
rinon
force-pushed
the
fw/should-segfault
branch
from
cdd308a to
55257b0
Compare
|
It looks like we need to delete the build directory in CI? #418 |
rinon
force-pushed
the
fw/should-segfault
branch
from
5a27f6c to
d0fefda
Compare
we previously tested for the printed message with FileCheck, but now our criterion-based tests care about exit codes this was hiding test failures on ARM64
rinon
force-pushed
the
fw/should-segfault
branch
from
d0fefda to
a94708b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously tested for the printed message with FileCheck, but now our Criterion-based tests only care about exit codes.
This was hiding test failures on both AArch64 and x86_64.
Based on bisecting it appears the
three_keys_minimaltest has never worked but its failures have always been masked by thetest_fault_handlerbug that this fixes. I'll look into things more tomorrow.