rewriter: warn on multiple compile commands per src and truncate to first one (reopened #398) #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert(comp_cmds.size() == 1)fails on templated files like indav1d#393.We discussed this separately, and besides just cases like
dav1dwhere this is done for templating reasons, this is also done in other places, I think for static and dynamic libraries maybe? Given that, it's simpler to just use the first compile command and emit a warning about it. We already emit warnings on other things that might be an issue (e.x. unsupported variadic function pointers), so I think this is okay.I accidentally merged #398 into a non-
mainbranch. This PR is intomaindirectly, and I'll merge it right away since #398 was already approved.