-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Integrate various ARM branches #424
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc6d8e6
to
55d64ce
Compare
55d64ce
to
8748530
Compare
e12ee3d
to
f986f93
Compare
rinon
reviewed
Oct 10, 2024
d9fdc1a
to
6372a16
Compare
8748530
to
59a82e1
Compare
d0067ed
to
b509501
Compare
Without this CTest only prints tests that fail so MTE check failures logged by QEMU won't show up unless the test fails for another reason.
this must apply to all code including PartitionAlloc. as such, we don't need to inject these specifically for libia2 and dependencies. while we're at it, ask specifically for armc8.5-a, which is where MTE and BTI support were added
rpath-link is needed for the link step, rpath is needed for runtime this may conflict with what CMake wants to do with rpaths, but seems to work for now
we were missing a second loop here
b509501
to
71aa5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the commits here from other branches are stale and others are modified compared to their upstream branch, but this successfully runs a number of tests locally with MTE enforced. PR for CI only for now.