Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle function pointers coerced to bool in ternary conditions #437

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

ayrtonm
Copy link
Contributor

@ayrtonm ayrtonm commented Oct 9, 2024

@ayrtonm ayrtonm requested a review from kkysen October 9, 2024 15:49
…operator

We already rewrite the conditions in the third and fourth tests correctly as
well as all the function pointers in the ternary branches.
Checks that function pointers in ternary branches that are not called are not
rewritten.
Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it fixes all of the cases of this in dav1d.

kkysen added a commit to immunant/dav1d that referenced this pull request Oct 13, 2024
@ayrtonm ayrtonm merged commit 40a9587 into main Oct 14, 2024
34 checks passed
@ayrtonm ayrtonm deleted the am/rewrite_ternary_conditions branch October 14, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewriter: IA2_ADDR not added in ? ternaries
2 participants