Improve static address taken function rewriting #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinon
force-pushed
the
sjc/static_addr_taken_used
branch
from
ce58ae2 to
669f781
Compare
Fixes a bug when the static function and its use are in different files (i.e. function definition is in a header).
rinon
force-pushed
the
sjc/static_addr_taken_used
branch
from
669f781 to
c811095
Compare
|
Weird, on my system the main binary identical name function is called correctly, but in CI it isn't. |
|
I'm disabling the identically named function part of the test. That should be fixed separately, as it is unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles adding
usedattribute to functions defined in headers or that begin with a macro expansion.