docs: add detailed docs of how dav1d was compartmentalized
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/docs-compartmentalizing-dav1d
branch
from
c052032 to
a525ce5
Compare
kkysen
force-pushed
the
kkysen/docs-compartmentalizing-dav1d
branch
from
a525ce5 to
7143b33
Compare
`IA2_DEFINE_SIGHANDLER` usage fixed in immunant/dav1d@a3a757f.
ayrtonm
reviewed
Nov 4, 2024
|
|
||
| Then there are overrides: | ||
|
|
||
| First just disabling some warnings/errors that `dav1d` enabled but IA2's runtime doesn't follow |
There was a problem hiding this comment.
I feel like we should support building with these flags at some point.
There was a problem hiding this comment.
Okay, though -Wno-unknown-warning-option we probably want to keep since I think it's a gcc vs clang thing.
ayrtonm
reviewed
Nov 4, 2024
ayrtonm
reviewed
Nov 4, 2024
…` is a `dav1d`-specific thing we added
… `partition-alloc-padding`, updated in #467
ayrtonm
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.