ARM: build and wire up dependencies in CI #461
Conversation
Without this CTest only prints tests that fail so MTE check failures logged by QEMU won't show up unless the test fails for another reason.
this must apply to all code including PartitionAlloc. as such, we don't need to inject these specifically for libia2 and dependencies. while we're at it, ask specifically for armc8.5-a, which is where MTE and BTI support were added
| # On aarch64, avoid swallowing QEMU MTE check failures | ||
| set(CMAKE_CTEST_COMMAND ${CMAKE_CTEST_COMMAND} --verbose) |
There was a problem hiding this comment.
Why not do this on x86 too?
There was a problem hiding this comment.
Our QEMU fork effectively runs in permissive mode, so this is necessary to distinguish test runs with violations from those without. On x86 compartment violations will end the program unconditionally and we'll see the output even on non-verbose test runs.
Ideally we would have this behavior be opted-into via a runtime flag instead of hard-coded in our QEMU fork.
There was a problem hiding this comment.
Our QEMU fork effectively runs in permissive mode, so this is necessary to distinguish test runs with violations from those without.
Right, we need this for tests that fail due to unintentional violations. I don't remember exactly what currently happens with CHECK_VIOLATION on ARM off the top of my head.
rpath-link is needed for the link step, rpath is needed for runtime this may conflict with what CMake wants to do with rpaths, but seems to work for now
fw-immunant
force-pushed
the
fw/arm-ci
branch
from
c7fdaf9 to
f945c64
Compare
|
Shouldn't we be passing |
I believe we unconditionally do this in |
No description provided.