rewriter: support the 6 x86 param regs for post condition functions #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/call-gate-post-condition-6-param-regs
branch
from
ced7990 to
fa355e9
Compare
Before either of these things I think we should explore what the checks themselves will look like. So trying out ways of allowing a developer to opt-in to simple checks or providing a way to specify their own more specific checks. In general I'd like us to have a more clear picture of what this looks like/maybe have an "end-to-end" demo or test before fixing the details like passing in arguments correctly for all possible function signatures. The same goes for return values although we may want to handle that earlier to support checks that are conditional on the return value. |
kkysen
force-pushed
the
kkysen/call-gate-post-condition-6-param-regs
branch
from
fa355e9 to
54dbe7e
Compare
kkysen
force-pushed
the
kkysen/call-gate-post-condition-call
branch
from
8a8db26 to
94bbdb3
Compare
kkysen
force-pushed
the
kkysen/call-gate-post-condition-6-param-regs
branch
from
54dbe7e to
b24b1bc
Compare
ayrtonm
reviewed
Dec 13, 2024
ayrtonm
reviewed
Dec 13, 2024
ayrtonm
approved these changes
Dec 13, 2024
kkysen
force-pushed
the
kkysen/call-gate-post-condition-6-param-regs
branch
from
b24b1bc to
d1ce1e0
Compare
kkysen
force-pushed
the
kkysen/call-gate-post-condition-call
branch
from
94bbdb3 to
82a087d
Compare
kkysen
force-pushed
the
kkysen/call-gate-post-condition-6-param-regs
branch
from
d1ce1e0 to
40bbda3
Compare
Base automatically changed from
kkysen/call-gate-post-condition-call
to
main
December 18, 2024 18:48
This is done by pushing the param regs onto the stack in the prologue (if there's a post condition function), and then popping them before we call the post condition function. Next we'll work on supporting more than the 6 param regs, as well as passing the return value.
…ich isn't supported yet This is a fatal error (ICE) since the caller can just set `--no-enable-dav1d_get_picture-post-condition`.
…g `pushq`s from `emit_prologue`
kkysen
force-pushed
the
kkysen/call-gate-post-condition-6-param-regs
branch
from
1dcaf11 to
5eaa9bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by pushing the param regs onto the stack in the prologue (if there's a post condition function), and then popping them before we call the post condition function.
Next we'll work on supporting more than the 6 param regs, as well as passing the return value.