Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument LLVM IR #1

Open
wants to merge 19 commits into
base: am/mte_instrumentation
Choose a base branch
from
Open

Instrument LLVM IR #1

wants to merge 19 commits into from

Conversation

fw-immunant
Copy link

No description provided.

@fw-immunant fw-immunant force-pushed the fw/instrument-llvm-ir branch 2 times, most recently from fb24602 to 242416c Compare October 5, 2024 19:45
@fw-immunant fw-immunant force-pushed the fw/instrument-llvm-ir branch from 242416c to 29239a7 Compare October 7, 2024 16:42
@fw-immunant fw-immunant force-pushed the fw/instrument-llvm-ir branch from dd900ef to 0e724f2 Compare October 18, 2024 21:33
@fw-immunant fw-immunant force-pushed the fw/instrument-llvm-ir branch from 0201415 to d8a86e2 Compare October 22, 2024 18:00
@fw-immunant fw-immunant force-pushed the fw/instrument-llvm-ir branch from dcbe96a to b510037 Compare October 22, 2024 23:59
@fw-immunant fw-immunant force-pushed the fw/instrument-llvm-ir branch from 6d75250 to ee4b89a Compare October 24, 2024 13:22
@fw-immunant fw-immunant force-pushed the fw/instrument-llvm-ir branch from ee4b89a to 07990b5 Compare October 24, 2024 15:33
@fw-immunant fw-immunant force-pushed the fw/instrument-llvm-ir branch from 5d149fa to bb1e362 Compare October 24, 2024 20:17
@ayrtonm ayrtonm self-assigned this Oct 28, 2024
@fw-immunant fw-immunant mentioned this pull request Oct 29, 2024
Open
ayrtonm
ayrtonm reviewed Nov 22, 2024
View reviewed changes
llvm/lib/Transforms/Utils/AArch64LoadStoreTagging.cpp
continue;
}

IRBuilder<> IRB(&*I);
Copy link

@ayrtonm ayrtonm Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to call IRB.SetInsertPoint? (at least before the CreateIntToPtr)

@ayrtonm
Copy link

ayrtonm commented Nov 22, 2024 •
edited
Loading

I feel like the incorrect pointer tagging here (adrp between str and and x9, x8, 0xff0000...) might be caused because we're not calling IRB.SetInsertPoint like this code or because we need to set the ordering of the loads/stores we instrument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrtonm ayrtonm ayrtonm left review comments

Assignees

@ayrtonm ayrtonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fw-immunant @ayrtonm