Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace parser functions with methods #13

Open
TheDan64 opened this issue Jan 21, 2020 · 4 comments
Open

Replace parser functions with methods #13

TheDan64 opened this issue Jan 21, 2020 · 4 comments
Assignees

Comments

@TheDan64
Copy link
Contributor

and add wrappers for public, no_mangle functions

@TheDan64 TheDan64 self-assigned this Jan 21, 2020
@rinon
Copy link
Contributor

rinon commented Jan 23, 2020

How’s this going? I’ve got changes on https://github.com/immunant/libexpat-rs/tree/encoding_references that I’m sure will conflict, so wanted to coordinate.

@TheDan64
Copy link
Contributor Author

TheDan64 commented Jan 23, 2020

It's still early, but going well so far. Currently trying to figure out how to get the FREE!, MALLOC!, etc macros to play nice with self. Once I get to the freeing code then maybe it'll get a little hairy. If your code is ready to merge we should do that soon before I get too far into it

@rinon
Copy link
Contributor

rinon commented Jan 23, 2020

Eventually we want to remove those macros, but in the mean time, just pass self as an ident in place of parser. If you need to use the macro outside of the parser then passing the memory allocator struct as an expr is better.

@TheDan64
Copy link
Contributor Author

TheDan64 commented Feb 3, 2020

This should be mostly done. There are still some remaining functions, mostly small but public-facing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants