Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Parser Fns to Methods: Part 2 #25

Merged
merged 5 commits into from
Feb 3, 2020
Merged

Convert Parser Fns to Methods: Part 2 #25

merged 5 commits into from
Feb 3, 2020

Conversation

TheDan64
Copy link
Contributor

@TheDan64 TheDan64 commented Jan 30, 2020 •
edited
Loading

Relates to #13

@TheDan64 TheDan64 requested review from ahomescu and rinon January 30, 2020 15:13
@TheDan64 TheDan64 self-assigned this Jan 30, 2020
@TheDan64 TheDan64 force-pushed the feature/self_methods_ext branch from 8b8d82a to 8796e58 Compare January 31, 2020 15:26
rinon
rinon approved these changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@rinon rinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDan64 TheDan64 merged commit 80ddc17 into master Feb 3, 2020
@TheDan64 TheDan64 deleted the feature/self_methods_ext branch February 3, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinon rinon rinon approved these changes

@ahomescu ahomescu Awaiting requested review from ahomescu

Assignees

@TheDan64 TheDan64

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDan64 @rinon