Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all usages of extern_types #28

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Remove all usages of extern_types #28

merged 2 commits into from
Jan 31, 2020

Conversation

TheDan64
Copy link
Contributor

Related to #18

@TheDan64 TheDan64 self-assigned this Jan 31, 2020
@rinon
Copy link
Contributor

rinon commented Jan 31, 2020

This is ok for now, although I'd prefer we did what the nomicon suggests instead.

Long term we should remove _IO_FILE and replace it with libc::FILE. We should get rid of as much of stdlib.rs as possible and replace them with libc types, but that's a more invasive change. We might even be able to get the refactorer to make some of those changes for us.

@TheDan64
Change void pointers to opaque structs
a45fcff 
as recommended by the nomicon
@TheDan64 TheDan64 merged commit 7a96e22 into master Jan 31, 2020
@TheDan64 TheDan64 deleted the feature/no_extern_types branch January 31, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinon rinon rinon approved these changes

Assignees

@TheDan64 TheDan64

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDan64 @rinon