Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC721 mint by quantity V2 #263

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

ERC721 mint by quantity V2 #263

wants to merge 37 commits into from

Conversation

drinkcoffee
Copy link
Contributor

Changes:

  • Made a copy of ImmutableERC721 contract and dependant contracts and called them V2 contracts. The only major differences are in the ERC721PSIV2 and ERC721PSIBurnable contracts.
  • Added interfaces for ERC721 contracts, so common features for contracts can sit behind an interface. This has allowed for the same tests to be used across implementations.
  • Migrated ERC721 HardHat tests to Forge.
  • Added many additional tests to improve test coverage.
  • Added perfTest directory, that includes test that check the gas efficiency of ERC721 contract implementations.

@drinkcoffee drinkcoffee requested a review from a team as a code owner February 7, 2025 05:54
@immutable-art immutable-art self-requested a review February 9, 2025 22:40
@drinkcoffee drinkcoffee requested a review from a team as a code owner February 9, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants