[!!!][TASK] Downgrade to PHP5.6

This change containts the downgraded source and test files, produced by rector/rector. This counts for the camt-lib and the iban lib (included) in the same way. Used command(s): ```shell tools/bin/rector process ```
impact-media-GmbH · Apr 26, 2023 · 65b786b · 65b786b
1 parent 1505473
commit 65b786b
Show file tree

Hide file tree

Showing 121 changed files with 3,061 additions and 1,089 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -7,6 +7,7 @@ jobs:
       matrix:
         php-version:
           - '5.6'
+          - '7.2'
           - '7.4'
 
     name: PHP ${{ matrix.php-version }}

diff --git a/composer.json b/composer.json
@@ -13,7 +13,7 @@
         ]
     },
     "require": {
-        "php": "~5.6 || ~7.4",
+        "php": "~5.6 || ~7.2 || ~7.4",
         "ext-dom": "*",
         "ext-libxml": "*",
         "ext-simplexml": "*",
@@ -34,6 +34,6 @@
         }
     },
     "require-dev": {
-        "phpunit/phpunit": "^5.7.27"
+        "phpunit/phpunit": "^5.7.19"
     }
 }
diff --git a/iban/Tests/CountryInfoTest.php b/iban/Tests/CountryInfoTest.php
@@ -25,7 +25,7 @@ final class CountryInfoTest extends TestCase
      */
     private $countryInfo;
 
-    protected function setUp(): void
+    protected function setUp()
     {
         $this->countryInfo = new CountryInfo('DE');
     }
@@ -56,6 +56,6 @@ public function testIbanCountryCreation()
      */
     private function getData()
     {
-        return include dirname(__DIR__, 1) . '/Resource/iban_registry_202009r88.php';
+        return include dirname(__DIR__) . '/Resource/iban_registry_202009r88.php';
     }
 }
diff --git a/iban/Tests/IbanTest.php b/iban/Tests/IbanTest.php
@@ -18,16 +18,25 @@ final class IbanTest extends TestCase
 {
     /**
      * @dataProvider ibanProvider
+     *
+     * @param string $iban,
+     * @param string $expectedCountryCode,
+     * @param string $expectedChecksum,
+     * @param string $expectedBban,
+     * @param string $expectedBbanBankIdentifier,
+     * @param string $expectedFormatElectronic,
+     * @param string $expectedFormatPrint,
+     * @param string $expectedFormatAnonymized
      */
     public function testIbanCreation(
-        string $iban,
-        string $expectedCountryCode,
-        string $expectedChecksum,
-        string $expectedBban,
-        string $expectedBbanBankIdentifier,
-        string $expectedFormatElectronic,
-        string $expectedFormatPrint,
-        string $expectedFormatAnonymized
+        $iban,
+        $expectedCountryCode,
+        $expectedChecksum,
+        $expectedBban,
+        $expectedBbanBankIdentifier,
+        $expectedFormatElectronic,
+        $expectedFormatPrint,
+        $expectedFormatAnonymized
     ) {
         $iban = new Iban($iban);
 

diff --git a/iban/Tests/Swift/RegistryTest.php b/iban/Tests/Swift/RegistryTest.php
@@ -23,7 +23,7 @@ final class RegistryTest extends TestCase
      */
     private $registry;
 
-    protected function setUp(): void
+    protected function setUp()
     {
         $this->registry = new Registry(new PhpRegistryLoader());
     }
@@ -56,6 +56,6 @@ public function testItShouldGiveCorrectValuesForCountryCode()
      */
     private function getData()
     {
-        return require dirname(__DIR__, 2) . '/Resource/iban_registry_202009r88.php';
+        return require dirname(dirname(__DIR__)) . '/Resource/iban_registry_202009r88.php';
     }
 }
diff --git a/iban/Tests/ValidatorTest.php b/iban/Tests/ValidatorTest.php
@@ -22,7 +22,7 @@ final class ValidatorTest extends TestCase
      */
     protected $validator;
 
-    protected function setUp(): void
+    protected function setUp()
     {
         $this->validator = new Validator([
             'violation.unsupported_country' => 'unsupported_country',

diff --git a/iban/src/Iban.php b/iban/src/Iban.php
@@ -23,15 +23,15 @@
  */
 class Iban
 {
-    public const FORMAT_ELECTRONIC = 'electronic';
-    public const FORMAT_PRINT = 'print';
-    public const FORMAT_ANONYMIZED = 'anonymized';
+    const FORMAT_ELECTRONIC = 'electronic';
+    const FORMAT_PRINT = 'print';
+    const FORMAT_ANONYMIZED = 'anonymized';
 
-    private const COUNTRY_CODE_OFFSET = 0;
-    private const COUNTRY_CODE_LENGTH = 2;
-    private const CHECKSUM_OFFSET = 2;
-    private const CHECKSUM_LENGTH = 2;
-    private const BBAN_OFFSET = 4;
+    const COUNTRY_CODE_OFFSET = 0;
+    const COUNTRY_CODE_LENGTH = 2;
+    const CHECKSUM_OFFSET = 2;
+    const CHECKSUM_LENGTH = 2;
+    const BBAN_OFFSET = 4;
 
     /**
      * @var string
@@ -98,7 +98,7 @@ public function getCountryCode()
         return substr($this->getNormalizedIban(), self::COUNTRY_CODE_OFFSET, self::COUNTRY_CODE_LENGTH);
     }
 
-    public function countryCode(): string
+    public function countryCode()
     {
         return substr($this->getNormalizedIban(), self::COUNTRY_CODE_OFFSET, self::COUNTRY_CODE_LENGTH);
     }
@@ -114,7 +114,7 @@ public function getChecksum()
         return substr($this->getNormalizedIban(), self::CHECKSUM_OFFSET, self::CHECKSUM_LENGTH);
     }
 
-    public function checksum(): string
+    public function checksum()
     {
         return substr($this->getNormalizedIban(), self::CHECKSUM_OFFSET, self::CHECKSUM_LENGTH);
     }
@@ -130,7 +130,7 @@ public function getBban()
         return substr($this->getNormalizedIban(), self::BBAN_OFFSET);
     }
 
-    public function bban(): string
+    public function bban()
     {
         return substr($this->getNormalizedIban(), self::BBAN_OFFSET);
     }
@@ -152,7 +152,7 @@ public function getBbanBankIdentifier()
         );
     }
 
-    public function bbanBankIdentifier(): string
+    public function bbanBankIdentifier()
     {
         $registry = new Registry(new PhpRegistryLoader());
 

diff --git a/iban/src/Swift/PhpRegistryLoader.php b/iban/src/Swift/PhpRegistryLoader.php
@@ -18,8 +18,8 @@
  */
 final class PhpRegistryLoader implements RegistryLoaderInterface
 {
-    public function load(): array
+    public function load()
     {
-        return require dirname(__DIR__, 2) . '/Resource/iban_registry_202009r88.php';
+        return require dirname(dirname(__DIR__)) . '/Resource/iban_registry_202009r88.php';
     }
 }
diff --git a/iban/src/Swift/RegistryLoaderInterface.php b/iban/src/Swift/RegistryLoaderInterface.php
@@ -18,5 +18,5 @@
  */
 interface RegistryLoaderInterface
 {
-    public function load(): array;
+    public function load();
 }
diff --git a/src/Camt052/DTO/Report.php b/src/Camt052/DTO/Report.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\DTO;
 
 use Genkgo\Camt\DTO\RecordWithBalances;

diff --git a/src/Camt052/Decoder/EntryTransactionDetail.php b/src/Camt052/Decoder/EntryTransactionDetail.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\Decoder;
 
 use Genkgo\Camt\Decoder\EntryTransactionDetail as BaseDecoder;
@@ -13,8 +11,10 @@ class EntryTransactionDetail extends BaseDecoder
 {
     /**
      * @inheritDoc
+     * @param \SimpleXMLElement|null $xmlRelatedPartyTypeAccount
+     * @return \Genkgo\Camt\DTO\Account|null
      */
-    public function getRelatedPartyAccount(?SimpleXMLElement $xmlRelatedPartyTypeAccount): ?DTO\Account
+    public function getRelatedPartyAccount($xmlRelatedPartyTypeAccount)
     {
         if (!$xmlRelatedPartyTypeAccount) {
             return null;

diff --git a/src/Camt052/Decoder/Message.php b/src/Camt052/Decoder/Message.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\Decoder;
 
 use Genkgo\Camt\Camt052\DTO as Camt052DTO;
@@ -14,7 +12,12 @@
 
 abstract class Message extends BaseMessageDecoder
 {
-    public function addRecords(DTO\Message $message, SimpleXMLElement $document): void
+    /**
+     * @param \Genkgo\Camt\DTO\Message $message
+     * @param \SimpleXMLElement $document
+     * @return void
+     */
+    public function addRecords($message, $document)
     {
         $reports = [];
 
@@ -47,7 +50,11 @@ public function addRecords(DTO\Message $message, SimpleXMLElement $document): vo
         $message->setRecords($reports);
     }
 
-    protected function getAccount(SimpleXMLElement $xmlRecord): Account
+    /**
+     * @param \SimpleXMLElement $xmlRecord
+     * @return \Genkgo\Camt\DTO\Account
+     */
+    protected function getAccount($xmlRecord)
     {
         if (isset($xmlRecord->Acct->Id->IBAN)) {
             return new DTO\IbanAccount(new Iban((string) $xmlRecord->Acct->Id->IBAN));

diff --git a/src/Camt052/Decoder/V01/Message.php b/src/Camt052/Decoder/V01/Message.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\Decoder\V01;
 
 use Genkgo\Camt\Camt052\Decoder\Message as BaseMessageDecoder;
@@ -11,8 +9,10 @@ class Message extends BaseMessageDecoder
 {
     /**
      * @inheritDoc
+     * @param \SimpleXMLElement $document
+     * @return \SimpleXMLElement
      */
-    public function getRootElement(SimpleXMLElement $document): SimpleXMLElement
+    public function getRootElement($document)
     {
         return $document->BkToCstmrAcctRptV01;
     }

diff --git a/src/Camt052/Decoder/V02/Message.php b/src/Camt052/Decoder/V02/Message.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\Decoder\V02;
 
 use Genkgo\Camt\Camt052\Decoder\Message as BaseMessageDecoder;
@@ -11,8 +9,10 @@ class Message extends BaseMessageDecoder
 {
     /**
      * @inheritDoc
+     * @param \SimpleXMLElement $document
+     * @return \SimpleXMLElement
      */
-    public function getRootElement(SimpleXMLElement $document): SimpleXMLElement
+    public function getRootElement($document)
     {
         return $document->BkToCstmrAcctRpt;
     }

diff --git a/src/Camt052/Decoder/V04/Message.php b/src/Camt052/Decoder/V04/Message.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\Decoder\V04;
 
 use Genkgo\Camt\Camt052\Decoder\Message as BaseMessageDecoder;
@@ -11,8 +9,10 @@ class Message extends BaseMessageDecoder
 {
     /**
      * @inheritDoc
+     * @param \SimpleXMLElement $document
+     * @return \SimpleXMLElement
      */
-    public function getRootElement(SimpleXMLElement $document): SimpleXMLElement
+    public function getRootElement($document)
     {
         return $document->BkToCstmrAcctRpt;
     }

diff --git a/src/Camt052/Decoder/V06/Message.php b/src/Camt052/Decoder/V06/Message.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\Decoder\V06;
 
 use Genkgo\Camt\Camt052\Decoder\Message as BaseMessageDecoder;
@@ -11,8 +9,10 @@ class Message extends BaseMessageDecoder
 {
     /**
      * @inheritDoc
+     * @param \SimpleXMLElement $document
+     * @return \SimpleXMLElement
      */
-    public function getRootElement(SimpleXMLElement $document): SimpleXMLElement
+    public function getRootElement($document)
     {
         return $document->BkToCstmrAcctRpt;
     }

diff --git a/src/Camt052/Decoder/V08/Message.php b/src/Camt052/Decoder/V08/Message.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\Decoder\V08;
 
 use Genkgo\Camt\Camt052\Decoder\Message as BaseMessageDecoder;
@@ -11,8 +9,10 @@ class Message extends BaseMessageDecoder
 {
     /**
      * @inheritDoc
+     * @param \SimpleXMLElement $document
+     * @return \SimpleXMLElement
      */
-    public function getRootElement(SimpleXMLElement $document): SimpleXMLElement
+    public function getRootElement($document)
     {
         return $document->BkToCstmrAcctRpt;
     }

diff --git a/src/Camt052/MessageFormat/V01.php b/src/Camt052/MessageFormat/V01.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Genkgo\Camt\Camt052\MessageFormat;
 
 use Genkgo\Camt\Camt052;
@@ -11,22 +9,34 @@
 
 final class V01 implements MessageFormatInterface
 {
-    public function getXmlNs(): string
+    /**
+     * @return string
+     */
+    public function getXmlNs()
     {
         return 'urn:iso:std:iso:20022:tech:xsd:camt.052.001.01';
     }
 
-    public function getMsgId(): string
+    /**
+     * @return string
+     */
+    public function getMsgId()
     {
         return 'camt.052.001.01';
     }
 
-    public function getName(): string
+    /**
+     * @return string
+     */
+    public function getName()
     {
         return 'BankToCustomerAccountReportV01';
     }
 
-    public function getDecoder(): DecoderInterface
+    /**
+     * @return \Genkgo\Camt\DecoderInterface
+     */
+    public function getDecoder()
     {
         $entryTransactionDetailDecoder = new Camt052\Decoder\EntryTransactionDetail(new Decoder\Date());
         $entryDecoder = new Decoder\Entry($entryTransactionDetailDecoder);