Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry-run flag to validate input files without running simulation #550

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexdewar
Copy link
Contributor

This PR adds a new --dry-run flag which can be passed to HGPS in order to validate input files without actually running a simulation. The idea is that it will enable @jzhu20 to check that the input data files are valid before submitting HPC jobs.

Closes #549.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 48.99%. Comparing base (0bec050) to head (2a68c85).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/HealthGPS.Console/program.cpp 0.00% 8 Missing ⚠️
src/HealthGPS.Console/command_options.cpp 82.35% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   48.98%   48.99%           
=======================================
  Files         164      164           
  Lines        7818     7831   +13     
  Branches     1063     1065    +2     
=======================================
+ Hits         3830     3837    +7     
- Misses       3979     3985    +6     
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great! This will help solve some headaches 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Allow for validating input files without starting actual simulation
2 participants