Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim common leading indention for Markdown #812

Closed
thawk opened this issue Jun 15, 2022 · 2 comments
Closed

Trim common leading indention for Markdown #812

thawk opened this issue Jun 15, 2022 · 2 comments

Comments

@thawk
Copy link
Contributor

thawk commented Jun 15, 2022

Currently, additional indentions is not allowed for Markdown, it will be recognized as indented code block. This makes it hard to using HTML formatter to format the code.

Suggest to remove the common leading indention for a Markdown code block. We can use the first non-blank line to detect the amount of leading spaces, than remove them before feeding to Markdown parser.
@henrikingo
Copy link
Member

Makes sense. I always write the Markdown left aligned, but a html editor may disagree with that, sure.

Oh, that reminds me... Filed #813 to capture an idea I had some years ago but apparently never created an issue.

thawk added a commit to thawk/impress.js that referenced this issue Jun 26, 2022
@thawk
Improve markdown support.
ea5f5aa 
1. Support `marked`, you can using it instead. impress#811
2. Auto detect slide title (using first non-blank line). impress#816
3. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
@thawk thawk mentioned this issue Jun 26, 2022
Merged
thawk added a commit to thawk/impress.js that referenced this issue Jun 26, 2022
@thawk
Improve markdown support.
6e0b372 
1. Support `marked`, you can using it instead. impress#811
2. Auto detect slide title (using first non-blank line). impress#816
3. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
thawk added a commit to thawk/impress.js that referenced this issue Jun 27, 2022
@thawk
Improve markdown support.
fcc340e 
1. Support `marked`, you can using it instead. impress#811
2. Auto detect slide title (using first non-blank line). impress#816
3. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
thawk added a commit to thawk/impress.js that referenced this issue Aug 15, 2022
@thawk
Improve markdown support.
cd5ce77 
1. Support `marked`, you can using it instead. impress#811
2. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
henrikingo pushed a commit that referenced this issue Aug 19, 2022
@thawk
Improve markdown support. (#817)
f8dd0e9 
1. Support `marked`, you can using it instead. #811
2. Auto trim the indentation, so it can be indent like regular HTML.
   #812
@thawk
Copy link
Contributor Author

thawk commented Oct 17, 2022

Closed by #817

@thawk thawk closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thawk @henrikingo