Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve markdown support. #817

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

thawk
Copy link
Contributor

@thawk thawk commented Jun 26, 2022

  1. Support marked, you can using it instead. Upgrade Markdown parser  #811
  2. Auto detect slide title (using first non-blank line). Auto detect slide title for markdown slides #816
  3. Auto trim the indentation, so it can be indent like regular HTML.
    Trim common leading indention for Markdown #812

@thawk thawk force-pushed the markdown_trim_indentation branch 2 times, most recently from 6e0b372 to fcc340e Compare June 27, 2022 01:10
@thawk thawk force-pushed the markdown_trim_indentation branch from 2d24e9c to 573e459 Compare July 5, 2022 06:44
@henrikingo
Copy link
Member

Hmm... May I ask you to submit a separate PR for each feature / issue.

In particular, I'm not convinced about #816 but would be happy to merge the others.

1. Support `marked`, you can using it instead. impress#811
2. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
@thawk
Copy link
Contributor Author

thawk commented Aug 15, 2022

Sorry, I forgot to update #816. I've update this PR to related to #811 and #812 only.

@henrikingo henrikingo merged commit f8dd0e9 into impress:master Aug 19, 2022
@henrikingo
Copy link
Member

Thanks. As far as I can see, this is ready to go as is! Nice work.

@thawk thawk deleted the markdown_trim_indentation branch August 23, 2022 09:46
@thawk thawk mentioned this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants