Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "touchY" plugin #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ArseniiLyzenko
Copy link

@ArseniiLyzenko ArseniiLyzenko commented Feb 16, 2020

Added a plugin that supports up/down swipes and touches to navigate. This is just a modification of the "touch" plugin.

@henrikingo
Copy link
Member

Hi Arsenii and thanks for contributing

It seems this is merely copying the functionality of the touch plugin. That doesn't seem like something I want to merge. Am I missing something?

henrik

@ArseniiLyzenko
Copy link
Author

henrik, you kinda right, this plugin adds support vertical swipes, and it is the slight modification of "touch" plugin that supports only horizontal swipes. So, the functionality of the original plugin "touch" and "touchY" the same, except directions of swipes.

@henrikingo
Copy link
Member

Why wouldn't you just add a configuration option to the existing plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants