Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight future substeps in slideView #841

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fnogatz
Copy link
Contributor

@fnogatz fnogatz commented Dec 26, 2022

In the current version of impress.js, the slideView in the impress-console is an exact copy of the slide that is currently presented. In my opinion, this ignores one essential benefit of this view, namely to additionally give the presenter hints on what is coming next.

This PR adds a CSS snippet that indicates the next substeps by a red border:

Screenshot from 2022-12-26 14-45-43

In addition, if at least one substep has the data-substep-order attribute set, the corresponding step number is displayed as well:

Screenshot from 2022-12-26 14-46-53

The highlighting is removed once the substep is displayed:

Screenshot from 2022-12-26 14-48-15

This PR is a follow-up on #825 and #827.

@henrikingo
Copy link
Member

This is a good idea, but I suggest a different implementation would be more elegant:

Change the logic of the preView window so that if there are substeps, it will show the next substep, not next slide.

@fnogatz
Copy link
Contributor Author

fnogatz commented Dec 27, 2022

Hm, but this way there's still no view that shows the final state of this slide. The highlighting not only serves the purpose of showing what will appear in the very next substep. Personally, I often need a reminder like "Don't talk about this point now, it will come later" 😅

@henrikingo
Copy link
Member

Ok fair point. So I would still argue that what you're proposing should be the preView window, and the slideView should be as similar to the real/main window as possible.

Once all the substeps are visible, then the slideView window should contain the current step with all substeps visible, and the preView window should show the next step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants