Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drones can now play music and always access a map #1228

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

hivehum
Copy link

@hivehum hivehum commented Jan 4, 2025

SS14 Loader_MGCbx0nJJ1

okay so the Original intent of this PR was to make it so drones have a map button. which i have implemented by giving them PAI component. but because i guess ECS is just a suggestion that comes with several other traits of PAIs, namely being able to play midis and also having a chance to die if microwaved. i'm fine with drones being able to play music and because they can't be picked up by players without admin intervention they cant be microwaved. so this is messy but fine, and doing this Right would involve splitting PAIComponent into three different components which may cause issues with upstream merging later

known issues

  • if a drone somehow gets microwaved it will display a locale string intended for PAIs. i didnt change this because its unlikely to come up in actual gameplay

Changelog
🆑

  • add: Drones can now sing a jaunty little tune and also check a map whenever they want.

Copy link

@Darkmajia Darkmajia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should rip pai stuff apart at some point maybe but ok fine

@Darkmajia Darkmajia merged commit 67d5a92 into impstation:master Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants