Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and fix build #273

Merged
merged 13 commits into from
Aug 25, 2023
Merged

Bump dependencies and fix build #273

merged 13 commits into from
Aug 25, 2023

Conversation

cyqsimon
Copy link
Collaborator

This will close a whole bunch of issues and PRs so I won't list them all here... Oh boy this is going to be fun.

- Binary build is fixed, but `packet_builder` crate seems to have some issues
@cyqsimon
Copy link
Collaborator Author

@imsnif What's the deal with this Travis stuff? Is it broken?

@imsnif
Copy link
Owner

imsnif commented Aug 17, 2023

@cyqsimon - travis removed their free tier for OSS projects. I'd recommend migrating to Github Actions.

@cyqsimon
Copy link
Collaborator Author

I see. I assume Travis integration was done using webhooks? In that case I would need settings permission on this repo to make these changes. Currently there's no project settings tab for me.

@imsnif
Copy link
Owner

imsnif commented Aug 17, 2023

@cyqsimon - I don't think I am able to give you such access (at least I couldn't find out how). If you tell me exactly what to do step-by-step for a one-shot, I can help out.

@cyqsimon
Copy link
Collaborator Author

I did a little research and it seems like it is indeed not possible, not on a personal repository. AFAIK the "GitHub way" to do this is to create an organisation account for bandwhich, transfer this repository to it, then add each of us as members.

See https://docs.github.com/en/organizations/collaborating-with-groups-in-organizations/about-organizations

@imsnif
Copy link
Owner

imsnif commented Aug 17, 2023

I understand @cyqsimon - but this is a level of commitment and work I do not want to get into at the moment. I'm happy to do as I offered above.

@cyqsimon
Copy link
Collaborator Author

If you tell me exactly what to do step-by-step for a one-shot, I can help out.

Ah are you're offering to remove the Travis branch protection predicate? I see. I thought you were referring to the permission stuff.

In this case, you would go to Settings > Code and automation > Branches > Branch protection rules, and there should be at least one rule relating to Travis. Delete that.

It's also a good idea to remove the dead Travis webhook (assuming it was triggered that way). Similarly, go to Settings > Code and automation > Webhooks, and delete the Travis hook.

These are the ones I can think of for the moment. Since I cannot access the settings tab, I'm not entirely sure whether there are other things that need changing. We'll cross that bridge when we get there.

@imsnif
Copy link
Owner

imsnif commented Aug 17, 2023

Removed the branch protection, there was no webhook. For the life of me I cannot remember how this was enabled.

@cyqsimon
Copy link
Collaborator Author

Hmm. It seems like Actions have been disabled. Odd considering the definition files exist in /.github/workflows.

To enable, go to Settings > Code and automation > Actions permissions > Allow all actions and reusable workflows.

Thanks!

@imsnif
Copy link
Owner

imsnif commented Aug 17, 2023

Done!

@cyqsimon
Copy link
Collaborator Author

The tests are failing en masse but at least it builds and CI works. I'll merge it for now and fix the tests later.

@cyqsimon cyqsimon merged commit 94df6e0 into main Aug 25, 2023
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants