Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in documentation #476

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ericwyles
Copy link

What this PR does / why we need it

I corrected a couple of problems in the template-policy.sh in the sigstore-keyless tutorial.

  • The jq commands had unnecessary . in the expression causing them not to evaluate
  • The sed commands had an unnecessary argument after -i causing the search string to be interpreted as a file name

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for witness-project ready!

Name Link
🔨 Latest commit 5344aca
🔍 Latest deploy log https://app.netlify.com/sites/witness-project/deploys/6688a481f278150008f50ab9
😎 Deploy Preview https://deploy-preview-476--witness-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sed -i '' "s|{{FULCIO_INT}}|$fulcio_int_b64|g" policy.json
sed -i '' "s|{{FREETSA_ROOT}}|$freetsa_root_b64|g" policy.json
sed -i '' "s|{{EMAIL}}|$email|g" policy.json
sed -i "s|{{FULCIO_ROOT}}|$fulcio_root_b64|g" policy.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the '' I'm getting this error on my Apple silicon Mac:

sed: 1: "policy.json": extra characters at the end of p command

What OS and shell program are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants