Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime Django Bugfix #152

Merged
merged 6 commits into from
Feb 16, 2017
Merged

Realtime Django Bugfix #152

merged 6 commits into from
Feb 16, 2017

Conversation

lucernae
Copy link
Contributor

@lucernae lucernae commented Feb 6, 2017

Various bug fix effort for Realtime Django

@lucernae lucernae changed the title Flood Realtime Bugfix Realtime Django Bugfix Feb 6, 2017
@lucernae
Copy link
Contributor Author

lucernae commented Feb 6, 2017

Changes:

screen shot 2017-02-08 at 06 32 05

@gubuntu
Copy link

gubuntu commented Feb 7, 2017

@lucernae we don't merge until travis passes, correct?

In ash upload form change 'meter' to 'meters' or 'metres' (Does InaSAFE have a policy on British vs American spelling?)

@Gustry
Copy link

Gustry commented Feb 7, 2017

In ash upload form change 'meter' to 'meters' or 'metres' (Does InaSAFE have a policy on British vs American spelling?)

It's metres.

@timlinux
Copy link
Contributor

timlinux commented Feb 7, 2017

Yes British english please

@lucernae
Copy link
Contributor Author

lucernae commented Feb 7, 2017

It's not done yet until @ivanbusthomi gives all the checkmark 😄

- change message for hazard upload page
- show latest flood as default. inasafe/inasafe-realtime#42
- add stroke color for hazard style. inasafe/inasafe-realtime#48
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4e821b1 on lucernae:develop into ** on inasafe:develop**.

@lucernae
Copy link
Contributor Author

lucernae commented Feb 8, 2017

@timlinux How do you configure coveralls?
Why did it show up even after it's not on AIFDR anymore?

@lucernae lucernae requested a review from ivanbusthomi February 8, 2017 04:22
@ivanbusthomi
Copy link
Contributor

I think the changes are great, especially the new filter function. Here are my comments on this:

  • in staging, I check the filter is not working. Is it still bugged?
  • Is it possible to change the layout of the filter a little bit? maybe something like this. Mas @samnawi, what do you think?
    image

@lucernae
Copy link
Contributor Author

lucernae commented Feb 8, 2017

in staging, I check the filter is not working. Is it still bugged?

@ivanbusthomi try hard refresh (shift + refresh or ctrl + refresh) so the new javascript is loaded.

Is it possible to change the layout of the filter a little bit? maybe something like this. Mas @samnawi, what do you think?

I think that's neat. It's possible to arrange it like that if that's ok with everyone.

@samnawi
Copy link

samnawi commented Feb 8, 2017

HI @ivanbusthomi That's great

- standardize color mapping in landing page: issue inasafe/inasafe-realtime#48
- default highlight latest flood report: issue inasafe/inasafe-realtime#42
- improvements for flood table: issue inasafe/inasafe-realtime#11
- add filters: issue inasafe/inasafe-realtime#11
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d782048 on lucernae:develop into ** on inasafe:develop**.

based on issue inasafe/inasafe-realtime#35

Celery:
- Limit prefetch multiplier explicitly to 1 (avoid hanging worker)

Earthquake:
- Add MMI Output FileField
- Add download button for MMI Output zip
- Auto zoom to first earthquake in the table

Flood:
- Fix signals to recalculate total affected population and flooded RW
- Add Data Source Field, since it needs to support PetaBencana
- Add code branching to handle old hazard data and new PetaBencana
- Add download button for Hazard File and Impact Layers
- Change download button icon to follow Earthquake pattern
- Auto zoom to first flood in the table

Ash:
- Add Impact Files FileField
- Add download button for Impact Files zip
- Change download button icon to follow Earthquake pattern
- Auto zoom to first ash event in the table
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e15f9ae on lucernae:develop into ** on inasafe:develop**.

@lucernae
Copy link
Contributor Author

lucernae commented Feb 10, 2017

Additional changes:

based on issue inasafe/inasafe-realtime#35

Earthquake:

  • Add download button for MMI Output zip (hide if it doesn't exists)
  • Auto zoom to first earthquake in the table

screen shot 2017-02-10 at 08 03 02

screen shot 2017-02-10 at 08 03 17

Flood:

  • Add support for PetaBencana
  • Add download button for Hazard File and Impact Layers (hide if it doesn't exists)
  • Change download button icon to follow Earthquake pattern

screen shot 2017-02-10 at 08 04 21

Ash:

  • Add download button for Impact Files zip (hide if it doesn't exists)
  • Change download button icon to follow Earthquake pattern
  • Auto zoom to first ash event in the table

screen shot 2017-02-10 at 08 05 29

screen shot 2017-02-10 at 08 05 36

@ivanbusthomi
Copy link
Contributor

ivanbusthomi commented Feb 10, 2017

This is great Mas @lucernae ,
👍

Just a few edit maybe, in my browser it looks like this
image

could you please check it?

@gubuntu
Copy link

gubuntu commented Feb 10, 2017

almost there.

@lucernae
Copy link
Contributor Author

@gubuntu Ash is deployed on staging. You have to login first for Ash. I will give the credentials later.

For the cropped part, I think that's because of the overflow. I'll see what I can do. But you should be able to horizontal scroll it to see the text?

@gubuntu
Copy link

gubuntu commented Feb 10, 2017

yes I can horizontal scroll. white space to the right of the text in that block could also be reduced.

@ivanbusthomi
Copy link
Contributor

Hi @gubuntu , and @lucernae
So here's my suggestion on reducing whitespace in the Filters area.
image

  • I think we can also make the warning text Value must be greater than or equal to 0. smaller, or just responsively resize the Filters box if the warning appear.
  • It would be great if the margin of Filters and Flood section are same.
  • The accept and clear button should be aligned with the other input maybe
  • Maybe also add Clear and Accept text on top of the button?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e15f9ae on lucernae:develop into ** on inasafe:develop**.

@lucernae
Copy link
Contributor Author

Some left issues were moved to #153 and I will merge this right away.

@lucernae lucernae merged commit f2abd66 into inasafe:develop Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants