Run specs with docker compose - add tests related to user email/IP #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pleary
requested changes
Oct 5, 2023
There was a problem hiding this comment.
I added a few comments about changes I needed to make to get tests to run in Docker on my ARM-based Mac.
I think it would also be helpful to have some documentation about using Docker for running tests. For example what commands to run to set up the images in the first place, and what commands to run after making changes to the code to rebuilding the images with the new code before running tests again.
The tests themselves are working well. But it would be great to at least make the change to the platform config so this works on ARM-based Mac before we merge this in.
|
Resolved the changes requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.