Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creative day project. I bailed on background uploading and settled for refactoring in an attempt to make our upload code make slightly more sense. A few things in here:
useEffect
inuseUploadObservations
to make it clear when and why uploads are startingstartIndividualUpload
function that works across the multi upload flow and MyObsuploadObservation
into bite-sized functions with clear namingaddObservationsToUploadQueue
function to set upload state (adding to queue, prepping the progress status) in a single functionuploadObservation
via theupdateTotalUploadProgress
callback, which makes it easy to see exactly when and why we're incrementing progress in a single fileuseToolbarTimeout
, since it has a single purpose to update state & doesn't have to do with the rest of the upload queue / progressWould be good to get a review on this since I'm sure I broke something / missed something. Hopefully this makes things a little less complicated.