Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving tests to the Github Action workflow #496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djarecka
Copy link

I've moved the tests to Github Action.

I've started changing the code to work with python3.7, but I've realized that I'd have to change also NIDM Results repo, so perhaps that should be done separately and should start from the NIDM Results repo. Let me know if you would like to do it and need some help.

The other thing that I've noticed is that running the tests (on my OSX with python 2.7) changes some files from the repo. Perhaps some files need updates.

@cmaumet
Copy link
Member

cmaumet commented Mar 22, 2021

Hi @djarecka! My apologies for the slow response. Thanks a lot for working on this!

I've started changing the code to work with python3.7, but I've realized that I'd have to change also NIDM Results repo, so perhaps that should be done separately and should start from the NIDM Results repo. Let me know if you would like to do it and need some help.

I've just checked and the nidmresults repository should already be Python 2 and Python 3 compatible (see here).

The other thing that I've noticed is that running the tests (on my OSX with python 2.7) changes some files from the repo. Perhaps some files need updates.

This has happened to both Karl and myself in the past and is usually due to a version of our dependencies being different locally compared to what is used by Travis for online testing (in particular the version of the markdown package). The current build in master is passing which means that the tests did not find any difference between what has been pushed and what is recomputed.

Let me know if I can provide more info. Thanks!

@djarecka
Copy link
Author

@cmaumet - also have some delays, sorry for this. I think I mistaken your repo with nidm-specs/nidm/nidm-results/scripts/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants