Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialisation using JSON-LD 1.1 #55

Merged
merged 11 commits into from
Jun 2, 2019
Merged

Add serialisation using JSON-LD 1.1 #55

merged 11 commits into from
Jun 2, 2019

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented May 15, 2019

@pep8speaks
Copy link

pep8speaks commented May 15, 2019 •
edited
Loading

Hello @cmaumet! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 701:57: W291 trailing whitespace

Comment last updated at 2019-05-29 12:11:34 UTC

@cmaumet cmaumet mentioned this pull request May 15, 2019
Open
@mih
Copy link
Contributor

mih commented May 23, 2019

That fix worked! Remaining issue is just a PY2 unicode thingie.

@cmaumet cmaumet added the READY_FOR_RELEASE PR ready for next round of releases (tests pass, review done). label May 24, 2019
@cmaumet
Merge pull request #2 from mih/idmap
0507edd 
RF: Provide an "interface" to perform ID mapping to an external DB
@cmaumet cmaumet mentioned this pull request May 29, 2019
Merged
@cmaumet cmaumet merged commit 0507edd into incf-nidash:master Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
READY_FOR_RELEASE PR ready for next round of releases (tests pass, review done).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaumet @pep8speaks @mih