Make RateLimitError implement error rather than making a pointer to i…

…t implement the error
incident-io · Apr 17, 2024 · 9ac6f7c · 9ac6f7c
1 parent 85875d8
commit 9ac6f7c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/misc.go b/misc.go
@@ -77,11 +77,11 @@ type RateLimitedError struct {
 	RetryAfter time.Duration
 }
 
-func (e *RateLimitedError) Error() string {
+func (e RateLimitedError) Error() string {
 	return fmt.Sprintf("slack rate limit exceeded, retry after %s", e.RetryAfter)
 }
 
-func (e *RateLimitedError) Retryable() bool {
+func (e RateLimitedError) Retryable() bool {
 	return true
 }
 

diff --git a/misc_test.go b/misc_test.go
@@ -2,6 +2,7 @@ package slack
 
 import (
 	"context"
+	"errors"
 	"log"
 	"net/http"
 	"net/url"
@@ -104,3 +105,10 @@ func TestRetryable(t *testing.T) {
 		}
 	}
 }
+
+func TestCanUseErrorsAs(t *testing.T) {
+	_ = errors.As(errors.New("error"), &RateLimitedError{})
+	_ = errors.As(errors.New("error"), &StatusCodeError{})
+	_ = errors.As(errors.New("error"), &SlackError{})
+	// no panic means we're good
+}