Don't marshal text property of links when it's empty #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slack returns an error if the text property is empty, but if it's not present everything is fine and it just uses the URL as the text of the link.
louisheath
approved these changes
Jan 10, 2025
| @@ -364,7 +364,7 @@ func NewRichTextSectionEmojiElement(name string, skinTone int, style *RichTextSe | |||
| type RichTextSectionLinkElement struct { | |||
| Type RichTextSectionElementType `json:"type"` | |||
| URL string `json:"url"` | |||
| Text string `json:"text"` | |||
| Text string `json:"text,omitempty"` | |||
There was a problem hiding this comment.
nice, I forgot about the omitempty tag
I guess it would have the same effect as changing this to *string , with less effort going around and fixing types
There was a problem hiding this comment.
Even if we changed the type to *string we'd still need omitempty so we didn't end up with "text": null in the JSON, which Slack also rejects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack returns an error if the text property is empty, but if it's not present everything is fine and it just uses the URL as the text of the link.