Fixes for usage of leader election #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controller-runtime has migrated to the native `lease` object some time ago, but this was missing in the manifests. Resolves this error: ``` 1 leaderelection.go:332] error retrieving resource lock theatre-system/workloads.crds.gocardless.com: leases.coordination.k8s.io "workloads.crds.gocardless.com" is forbidden: User "system:serviceaccount:theatre-system:theatre-workloads-manager" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "theatre-system" ```
As per the documentation for this option, we can do this to speed up lease transitions, given that in our codebase we only ever immediately exit the process if the manager is cancelled.
There's no reason to have these around any longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to start using leader election, so that we can have multiple pods running, in order to serve webhooks reliably.
The functionality for this is already available, but there's some tweaks here to make it work.
Commits:
Add leases RBAC to base config
controller-runtime has migrated to the native
leaseobject some timeago, but this was missing in the manifests.
Resolves this error:
Release leader election lease on shutdown
As per the documentation for this option, we can do this to speed up
lease transitions, given that in our codebase we only ever immediately
exit the process if the manager is cancelled.
Remove dangerous targets from Makefile
There's no reason to have these around any longer.