openssl/gen_cert: mark evidence extension as non-critical #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
15 tasks
haosanzi
reviewed
Feb 27, 2023
| // * However, there is no way via the openssl api to know directly which extension is causing | ||
| // * X509_V_ERR_UNHANDLED_CRITICAL_EXTENSION, so we have to tolerate all this cases here. | ||
| // * This may be a security issue if there are other critical extensions that neither we nor openssl can handle. | ||
| // * See: |
There was a problem hiding this comment.
why add '//' before '/*/'?
There was a problem hiding this comment.
replaced with #if 0 and #fi
Mark evidence extensions as non-critical, since many TLS libraries (such as openssl or mbedtls) do not support extracting critical extensions. See: CCC-Attestation/interoperable-ra-tls#9 Signed-off-by: Kun Lai <[email protected]>
imlk0
force-pushed
the
non-critical-extension
branch
from
81db134 to
680f11f
Compare
haosanzi
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark evidence extensions as
non-critical, since many TLS libraries (such as openssl or mbedtls) do not support extracting critical extensions.See: CCC-Attestation/interoperable-ra-tls#9
Signed-off-by: Kun Lai [email protected]