Silence unused warnings related to tests #2324
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazunki
force-pushed
the
fix-silence-unused-parameters2
branch
from
a3e65a9 to
7eb6b23
Compare
mazunki
force-pushed
the
fix-silence-unused-parameters2
branch
from
fc77144 to
4abfe60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2320 , but addressing tests.
@alfreb
test/kernel/integration/paging/service.cpphas an unusedheap_codevariable. I see you updated this test in 2019.The
void(*heap_code)() = (void(*)()) malloc(42);line is at the very beginning of the test. I suspect the intention of this is to warm of the allocator. Did you mean to change this tomagic->heap_code?I don't want to touch the tests based on assumptions on what the intention was, without fully understanding what the idea behind it was.
Additionally,
Expects(magic->last_error = Page_fault);is surely a subtle bug? That=should be==, right?