fix: consolidate error handling into catch (resolves #24) (#25)

fix: set GIT_HOSTNAME for GitLab (resolves #23)
chore(docs): add note about GIT_HOSTNAME
fix: add NVM configuration

.nvmrc

@@ -0,0 +1 @@
+20.x

README.md

@@ -24,6 +24,8 @@ OAUTH_CLIENT_ID=""
 OAUTH_CLIENT_SECRET=""
 ```
 
+If you are using GitHub Enterprise Server or a self-hosted instance of GitLab you'll also need to set `GIT_HOSTNAME` to the hostname of your server.
+
 ### Serving locally
 
 1. Install the required packages: `npm install`

middleware/index.js

@@ -67,7 +67,7 @@ const authMiddleware = () => {
 			ALLOWED_DOMAINS,
 			OAUTH_CLIENT_ID,
 			OAUTH_CLIENT_SECRET,
-			GIT_HOSTNAME = "github.com",
+			GIT_HOSTNAME = provider === "github" ? "github.com" : "gitlab.com",
 		} = process.env;
 
 		// Check if the domain is whitelisted
@@ -191,7 +191,7 @@ const callbackMiddleware = () => {
 		const {
 			OAUTH_CLIENT_ID,
 			OAUTH_CLIENT_SECRET,
-			GIT_HOSTNAME = "github.com",
+			GIT_HOSTNAME = provider === "github" ? "github.com" : "gitlab.com",
 		} = process.env;
 
 		if (!OAUTH_CLIENT_ID || !OAUTH_CLIENT_SECRET) {
@@ -245,10 +245,6 @@ const callbackMiddleware = () => {
 				body: JSON.stringify(requestBody),
 			});
 		} catch {
-			//
-		}
-
-		if (!response) {
 			res.set(defaultHeaders);
 			res.send(
 				htmlResponse({

package.json

@@ -14,13 +14,7 @@
 		"prepare": "husky",
 		"test": "c8 --all -r clover -r text ava"
 	},
-	"keywords": [
-		"decap-cms",
-		"sveltia-cms",
-		"github",
-		"gitlab",
-		"auth"
-	],
+	"keywords": ["decap-cms", "sveltia-cms", "github", "gitlab", "auth"],
 	"author": "OCAD University <[email protected]>",
 	"license": "BSD-3-Clause",
 	"dependencies": {
@@ -37,8 +31,6 @@
 		"supertest": "^7.0.0"
 	},
 	"lint-staged": {
-		"*.{js,json}": [
-			"biome check --write --no-errors-on-unmatched"
-		]
+		"*.{js,json}": ["biome check --write --no-errors-on-unmatched"]
 	}
 }