Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lodash types #777

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Add lodash types #777

merged 5 commits into from
Aug 20, 2024

Conversation

fabienheureux
Copy link
Member

@fabienheureux fabienheureux commented Aug 14, 2024

Il manque les types Lodash.

Ça supprime un warning typescript et apporte un meilleur typage

@fabienheureux fabienheureux marked this pull request as ready for review August 14, 2024 10:34
@fabienheureux fabienheureux requested a review from a team as a code owner August 14, 2024 10:34
@fabienheureux fabienheureux requested review from Hazelmat and removed request for a team August 14, 2024 10:34
Copy link
Contributor

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabienheureux : j'ai l'impressin qu'il y a un petit pb de dépendance à résoudre coté JS

cf. https://github.com/incubateur-ademe/quefairedemesobjets/actions/runs/10386049237/job/28764583039?pr=777

@fabienheureux
Copy link
Member Author

j'ai vu ouais, je reprends le sujet

@fabienheureux fabienheureux removed the request for review from Hazelmat August 14, 2024 13:57
@fabienheureux fabienheureux assigned fabienheureux and unassigned kolok Aug 14, 2024
@fabienheureux
Copy link
Member Author

Cf parcel-bundler/watcher#152 (comment)
On a exactement le même soucis dans notre action GitHub en erreur, j'ai donc tenté d'ajouter la dépendance optionnelle en suivant ce qui est fait dans cette issue

@fabienheureux
Copy link
Member Author

@kolok on va y arriver 😬

@fabienheureux fabienheureux assigned kolok and unassigned fabienheureux Aug 19, 2024
Copy link
Contributor

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabienheureux fabienheureux merged commit 20bc465 into main Aug 20, 2024
7 checks passed
@fabienheureux fabienheureux deleted the add-lodash-types branch August 20, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants