Support for template url #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attribute: template-url="'myTemplateUrl'"
attribute: template-url="'myTemplateUrl'"
attribute: template-url="'myTemplateUrl'"
attribute: template-url="'myTemplateUrl'"
attribute: template-url="'myTemplateUrl'"
attribute: template-url="'myTemplateUrl'"
wytrych
reviewed
Dec 5, 2016
| @@ -1,7 +1,7 @@ | |||
| # angular-bind-html-compile | |||
| This repo contains a bower package that provides an angular directive which can be passed trusted html with angular template content to evaluate. | |||
|
|
|||
| The `bind-html-compile` directive allows for HTML containing directives to be compiled. | |||
| The `bind-html-compile` directive allows for HTML containing **custom** directives to be compiled. | |||
There was a problem hiding this comment.
I don't think that this change is needed, since it doesn't matter if these are custom or angular core directives
wytrych
reviewed
Dec 5, 2016
| ``` | ||
|
|
||
| If the `data.content` contained a directive, it would not be compiled. | ||
| (Unlike the standard `ng-bind-html`, `bind-html-compile` compiles directives, and even those custom ones.) |
There was a problem hiding this comment.
Again adding the information about "custom directives" is probably too much
|
Could you please add more meaningful names to your commits? |
|
Sorry for the misleading about my several commits. Actually the other repeated ones were only to fix the styling warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code has been implemented to support template files:
<div bind-html-compile template-url="data.templateUrl"></div>knowing that both attributes still work together:
<div bind-html-compile="data.content" template-url="data.templateUrl"></div>