Add management command to notify and delete users #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinetienne
force-pushed
the
add-command-notify-user
branch
from
c176791
to
5dee891
Compare
kevinetienne
changed the title
|
@Ian-Foote @adam-thomas @nologo can you review please? |
| class TestUserNotifyManagementCommand(TestCase): | ||
| def test_no_users(self): | ||
| call_command('notify_users') | ||
| self.assertFalse(len(mail.outbox)) |
There was a problem hiding this comment.
I'd prefer assertEqual(0).
There was a problem hiding this comment.
👍 for this, personally. Not a dealbreaker for me though.
added 3 commits
April 28, 2016 11:50
Give them a more explicit name
|
Updated and thanks for the review! |
|
LGTM, nice one! :) It occurs to me that the 'account deleted' email sounds quite hostile. Where does that copy come from? |
|
It comes from diabates coach |
|
OK cool, fine by me then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.