refactor: remove dependence on env vars and rely on forge injected entities #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundry has since been updated to the point where relying on environment variables to inject accounts is no longer necessary.
BatchScript.sol
is aforge script
and thus already has a signer andchainId
configured when the script is run. There should be no need to rely on environment variables to duplicate what is already natively injected byforge
.In addition,
vm.sign
has been recently updated to allow for signing of messages directly via whatever wallet has been selected viaforge script
options, thus there is no need for complex string logic to assemble an externalcast
call anymore.forge
already allows usage of plaintext keys, keystores, and hardware wallets so this shouldn't result in any loss of functionality.Haven't tested it with hardware wallets though, not sure if
vm.sign
can correctly identify a--sender
with a ledger/trezor provided via options.