feat: Simulate when txn is added for return values #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the simulation logic to allow for getting return values from scripts. This is potentially in various situations where you need an intermediate value for the next step in a batch, such as an address that is deployed.
Adding this required initializing the batch data prior to the end of the script and having the
safeaddress available within theaddToBatchfunction. Therefore, I added anisBatch(address)modifier that can be used on any script functions that will use batches to set this data up front. The examples had hard-coded safe addresses, but it can as easily be passed into the script as a parameter.There are some breaking changes for scripts created with the old interface, so may be good to tag as a new version.