DRAFT: Refactoring RPCWithMemoTest so to make easier to re-implement in Go #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes as a consequence of trying to implement indeedeng/iwf-golang-sdk#64. After completing the model, I had to migrate the tests and it was very hard to make sense of the existing one.
Overall, I propose the following improvements:
Thread.sleep
in tests and delegate eventuay consistency matching logic to a library, in this caseawaitility
@BeforeEach
rather than at the beginning of each testTODO:
Further improvement down the line:
@TestFactory
JUnit annotation so to automatically generate the testcases for Func1, Func0 and Proc1/Proc0