Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WaitForStateCompletion API with strongly typing experience, and rename getSimpleWorkflowResultWithWait to waitForWorkflowCompletion #216

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

longquanzheng
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (08a5d25) 71.69% compared to head (8e0137c) 71.63%.

❗ Current head 8e0137c differs from pull request most recent head f289add. Consider uploading reports for the commit f289add to get more accurate results

Files Patch % Lines
...iworkflow/core/WorkflowOptionBuilderExtension.java 70.00% 3 Missing ⚠️
src/main/java/io/iworkflow/core/Client.java 80.00% 1 Missing ⚠️
...c/main/java/io/iworkflow/core/WorkflowOptions.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #216      +/-   ##
============================================
- Coverage     71.69%   71.63%   -0.06%     
- Complexity      397      404       +7     
============================================
  Files            61       62       +1     
  Lines          1639     1657      +18     
  Branches        149      149              
============================================
+ Hits           1175     1187      +12     
- Misses          387      393       +6     
  Partials         77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@longquanzheng longquanzheng changed the title Add WorkflowOptionBuilderExtension for better experience Improve WaitForStateCompletion API with strongly typing experience Feb 21, 2024
@longquanzheng longquanzheng changed the title Improve WaitForStateCompletion API with strongly typing experience Improve WaitForStateCompletion API with strongly typing experience, and rename getSimpleWorkflowResultWithWait to waitForWorkflowCompletion Feb 21, 2024
@longquanzheng longquanzheng merged commit 392a3c5 into main Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant