Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira/katiea/iwf 122 #264

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Jira/katiea/iwf 122 #264

merged 5 commits into from
Nov 15, 2024

Conversation

ktrops
Copy link
Contributor

@ktrops ktrops commented Nov 14, 2024

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is NOT backwards-compatible)

Related Issue

Closes #<issue_number>

@ktrops ktrops force-pushed the jira/katiea/IWF-122 branch from 8eca714 to db0d506 Compare November 14, 2024 22:26
@@ -32,6 +32,8 @@ for run in {1..120}; do
sleep 0.1
temporal operator search-attribute create --name CustomKeywordArrayField --type KeywordList
sleep 0.1
temporal operator search-attribute create --name CustomTextField --type Text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, what happened to this before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know why this didn't show up before. My previous MR failed the integration tests when I merged. This is a fix for that.

@ktrops ktrops merged commit 815987c into main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants