Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHPUnit 10 and Laravel 10.x #47

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Braunson
Copy link

@Braunson Braunson commented Mar 3, 2023

  • Add support for PHPUnit 10 (and Laravel 10.x in the process)
  • Added Travis support for testing in PHP 8.1

Add support for PHPUnit 10
@Braunson Braunson changed the title Suppor for PHPUnit 10 Support for PHPUnit 10 and Laravel 10.x Mar 7, 2023
@ventrec
Copy link
Member

ventrec commented Mar 8, 2023

The build with PHP 8.1 fails on travis. This is related to an outdated composer.lock file in this repository. I think we might need to do a bit of cleaning here before adding support to php 8.1.

@Braunson
Copy link
Author

Braunson commented Mar 8, 2023

@ventrec Ah yeah, we'll need to switch away from listeners and to use the new Event/subscribers system for PHPUnit 10. I've made progress converting the package but I'm not sure how to override the output of PHPUnit. The write/writeWithColor methods don't seem to do anything now?

@Braunson Braunson marked this pull request as draft March 21, 2023 13:52
@robiningelbrecht
Copy link

FYI: I'm working on a PHPUnit pretty output based on https://pestphp.com/docs/installation. I'm using PHPUnit 10 and got an working example...

@Braunson
Copy link
Author

Braunson commented Apr 3, 2023

@robiningelbrecht How close of a replacement to this package is it and when will it be ready?

@robiningelbrecht
Copy link

robiningelbrecht commented Apr 3, 2023

@Braunson it's ready and based on Pest PHPs output. Not sure if I should post it here? It's a separate repo

@robiningelbrecht
Copy link

robiningelbrecht commented Apr 3, 2023

@robiningelbrecht How close of a replacement to this package is it and when will it be ready?

Just check my repo's it's in the list :)
Let me know what you think

@TomasVotruba
Copy link

TomasVotruba commented Aug 20, 2023

@robiningelbrecht I think it's this one, right? https://github.com/robiningelbrecht/phpunit-pretty-print

I love Pest output... so I'm on it :)

@robiningelbrecht
Copy link

@TomasVotruba indeed it is :)

@TomasVotruba
Copy link

@robiningelbrecht I see :) thanks. I'm just trying it and it seems it can be only enabled in every run in xml.
Is there some way to turn it optionally in the CLI? I want to have PHPUnit runner by default and enable this one only for debugging.

E.g.:

vendor/bin/phpunit --output-formatter=PrettyOne

Any idea how to achieve this?

@robiningelbrecht
Copy link

robiningelbrecht commented Aug 20, 2023

@TomasVotruba no, not right now. Could you create a feature request in the issue queue? I'll look into it. Let's move the discussion there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants