Create AUP page #29
Draft
Create AUP page #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogasp
reviewed
Jun 3, 2024
There was a problem hiding this comment.
This component should be placed to /src/app/(pages)/aup/components/ instead of /src/app/(page)/components
jacogasp
reviewed
Jun 3, 2024
| import { Aup } from "@/models/aup"; | ||
|
|
||
| const calculate = (aup: Aup) => { | ||
| const newDate = new Date(aup?.lastUpdateTime as Date); |
There was a problem hiding this comment.
Why create a new Date from a Date?
There was a problem hiding this comment.
What about if aup is not defined?
SteDev2
force-pushed
the
28-create-aup-page
branch
from
f39dd5a
to
e2b4760
Compare
jacogasp
force-pushed
the
28-create-aup-page
branch
from
e2b4760
to
2a4823d
Compare
jacogasp
force-pushed
the
28-create-aup-page
branch
from
2a4823d
to
1eac1e4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.