Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check password quality on update password #719

Merged
merged 29 commits into from
Aug 2, 2024
Merged

Add check password quality on update password #719

merged 29 commits into from
Aug 2, 2024

Conversation

SteDev2
Copy link
Contributor

@SteDev2 SteDev2 commented Feb 29, 2024

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
1 Security Hotspot
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SteDev2 SteDev2 marked this pull request as draft March 18, 2024 13:32
@enricovianello enricovianello linked an issue Jun 5, 2024 that may be closed by this pull request
Local accounts: check password quality #544
Closed
@SteDev2 SteDev2 marked this pull request as ready for review June 10, 2024 14:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SteDev2 SteDev2 requested a review from rmiccoli July 25, 2024 09:51
@rmiccoli
Copy link
Contributor

Quality Gate Failed Quality Gate failed

Failed conditions 76.0% Coverage on New Code (required ≥ 85%)

See analysis details on SonarCloud

Try to solve issues and improve coverage

rmiccoli
rmiccoli requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@rmiccoli rmiccoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix small typos and resolve comments

@rmiccoli
Copy link
Contributor

In the resetPassword method of the DefaultPasswordResetService service, it's better to move the event publication at the end, after changing the password and saving the account.

@rmiccoli
Copy link
Contributor

rmiccoli commented Aug 2, 2024

In the resetPassword method of the DefaultPasswordResetService service, it's better to move the event publication at the end, after changing the password and saving the account.

Done by @SteDev2 :)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 2, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rmiccoli
Copy link
Contributor

rmiccoli commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues 0 New issues 1 Accepted issue

Measures 1 Security Hotspot 100.0% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarCloud

The security hotspot is a false positive, so it can be considered safe.

@enricovianello enricovianello merged commit 9c5eb72 into develop Aug 2, 2024
4 checks passed
@enricovianello enricovianello deleted the issue-544 branch August 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricovianello enricovianello enricovianello left review comments

@rmiccoli rmiccoli rmiccoli approved these changes

Assignees

@SteDev2 SteDev2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local accounts: check password quality
3 participants
@SteDev2 @rmiccoli @enricovianello