Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC figures 2023 #18

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

IBC figures 2023 #18

wants to merge 11 commits into from

Conversation

ferponcem
Copy link
Contributor

@ferponcem ferponcem commented Feb 13, 2023

Some notes:

  • These figures were obtained using 11 subs and 7 tasks: MathLanguage, SpatialNavigation, EmoReco, EmoMem, StopNogo, FingerTapping, and VSTMC.
  • This is a work in progress, for the condition_similarity_cognitive we're lacking some cognitive tags to generate the last figure.

@bthirion
Copy link
Member

I'm afraid something when wrong with the PR since it contains all csv files.

@ferponcem ferponcem closed this Feb 14, 2023
@ferponcem ferponcem deleted the IBCfigures_2023 branch February 14, 2023 17:04
@ferponcem ferponcem restored the IBCfigures_2023 branch February 14, 2023 17:07
@ferponcem ferponcem reopened this Feb 14, 2023
@ferponcem ferponcem closed this Feb 15, 2023
@ferponcem ferponcem deleted the IBCfigures_2023 branch February 15, 2023 10:54
@man-shu man-shu reopened this Feb 15, 2023
@ferponcem
Copy link
Contributor Author

I'm afraid something when wrong with the PR since it contains all csv files.

Yes, my bad.
Sorry for the mess, I hope it's better now.

@ferponcem
Copy link
Contributor Author

Some comments:

  • I did not follow the previous structure of the folder where all the scripts are in one place, because I thought separating them so each folder contains their figures could be easier for the visualization on the first times (so you don't have to run each time to see changes). Maybe we can delete the figures and go back to the previous structure once we're clear with the content.

  • For the data_quality script, I also included Nifti files, but maybe this is not the best practice, I am thinking we can remove all images when we have some more advance version of the code, I am just leaving them here now in case you just want to open them up quickly.

@ferponcem
Copy link
Contributor Author

I am naming everything with 3 or third_rel, trying to make a reference to third release, since the codes I modified were for the second one. I can change this if needed.

@ferponcem
Copy link
Contributor Author

I am not sure that the condition_similarity_within figure, on the global_stats3 folder is correct, I am not sure what that pattern means. Here we can wait a bit until we get the twin figure of cognitive similarity (where we need the tags) to see if it's similar, and I will also check the code again in case there's files missing or warnings I didn't see.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I did not have time to heck in detail the code, which looks good overall. Is there anything I should look at in particular ?

@@ -0,0 +1,79 @@
"""
Analysis of the coverage of brain maps.
Authors: Bertrand Thirion, Ana Luisa Pinho 2020
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated for sure ;-)

papers_scripts/release2023/global_stat3/global_stat3.py Outdated Show resolved Hide resolved
@ferponcem
Copy link
Contributor Author

Sorry I did not have time to heck in detail the code, which looks good overall. Is there anything I should look at in particular ?

Just a quick look to the figures to see whether they make sense. We can discuss more details on our next IBC meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants