PytatoPyOpenCLArrayContext: don't trust the arg limit reported by the GPU #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPU Apparently, CUDA doesn't like it when argument sizes get close to the reported limit. Avoids PTX/JIT errors of the type CUDA_ERROR_INVALID_IMAGE: device kernel image is invalid CUDA_ERROR_FILE_NOT_FOUND: file not found
|
Interesting. That's a weird error message for "too many arguments". |
|
LMK when you think this is ready. |
|
I have tested this and it seems to return us to the previous state described in illinois-ceesd/mirgecom#679. This was a regression from my gist which set a fixed limit of 1024 on all devices. @MTCam also experimented with this PR. This is ready for review. |
inducer
approved these changes
Sep 26, 2022
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, CUDA doesn't like it when argument sizes get close to the reported limit.
Avoids PTX/JIT errors of the type:
CUDA_ERROR_INVALID_IMAGE: device kernel image is invalid
CUDA_ERROR_FILE_NOT_FOUND: file not found
Partially addresses illinois-ceesd/mirgecom#679