Implement Batched Einsum ArrayContext #217
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
force-pushed
the
batched_einsum_actx
branch
8 times, most recently
from
85f0e00
to
fb42c99
Compare
kaushikcfd
force-pushed
the
batched_einsum_actx
branch
5 times, most recently
from
c3b8016
to
df4e8d4
Compare
Otherwise Intel OpenCL gets its integer arithmetic wrong.
kaushikcfd
force-pushed
the
batched_einsum_actx
branch
2 times, most recently
from
c6f269f
to
bfdba11
Compare
kaushikcfd
force-pushed
the
batched_einsum_actx
branch
3 times, most recently
from
5efcedd
to
e929e2d
Compare
kaushikcfd
force-pushed
the
batched_einsum_actx
branch
from
e929e2d
to
8211a9c
Compare
2 tasks
inducer
reviewed
Sep 6, 2023
| domain = t_unit[kernel_name].get_inames_domain(loop_nest.inames) | ||
| if frozenset(domain.get_var_dict()) != loop_nest.inames: | ||
| raise NotImplementedError("Current implementation requires" | ||
| " ") |
Comment on lines
+520
to
+521
| in0({subst_rule_args}) := 3.141592653589793 | ||
| in1({subst_rule_args}) := 2.718281828459045 |
There was a problem hiding this comment.
Values for
Adds a failing test for the dimension mismatch error.
avoid loop-fusion errors associated with saturations of long dimensions
kaushikcfd
force-pushed
the
batched_einsum_actx
branch
from
8bc3e14
to
caaa471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft because: