Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for integral computations when using overintegration #216

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomasgibson
Copy link
Collaborator

No description provided.

@thomasgibson thomasgibson linked an issue Jan 28, 2022 that may be closed by this pull request
return DOFArray(
actx,
data=tuple(
actx.einsum("ei,i,ei->ei",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
actx.einsum("ei,i,ei->ei",
# FIXME: Using einsum only for the benefit of eager eval.
# With proper broadcasting, this should likely just be
# a multiplication.
actx.einsum("ei,i,ei->ei",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elementwise_integral doesn't respect quadrature rules
2 participants